Require Node.js 8, return undefined instead of null, add TypeScript definition
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BendingBender
changed the title
undefined instead of null, add TypeScript definitionundefined instead of null, add TypeScript definition
BendingBender
changed the title
undefined instead of null, add TypeScript definitionundefined instead of null, add TypeScript definition
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sindresorhus Currently, tests fail because
npm@5started to link packages installed from local paths (ones withfile:urls) in contrast to older versions of npm which copied such packages over tonode_modules.I'm not sure how you would prefer to resolve this. Should we just manually copy the fixture package over to
node_modules? Do you know of a better solution?Waiting for sindresorhus/resolve-from#12.