Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for empty separator #53

Merged
merged 6 commits into from
Jul 18, 2020
Merged

Add support for empty separator #53

merged 6 commits into from
Jul 18, 2020

Conversation

Arnovsky
Copy link
Contributor

@Arnovsky Arnovsky commented Jul 17, 2020 •
edited by sindresorhus
Loading

Fixes #52

@sindresorhus
Copy link
Owner

I think it should be explicitly documented as it's not immediately obvious that it's supported. Could add another example (in readme and index.d.ts).

@sindresorhus sindresorhus changed the title Added support for empty seperator Add support for empty separator Jul 17, 2020
@Arnovsky
Copy link
Contributor Author

Arnovsky commented Jul 17, 2020 •
edited
Loading

CI seems to failing due to an unrelated issue, something with transliterate breaking with version 0.1.1 in this commit, I have change the tests accordingly.

@Arnovsky
Copy link
Contributor Author

@sindresorhus Is the documentation added OK?

@sindresorhus sindresorhus merged commit d7bf7cc into sindresorhus:master Jul 18, 2020
@sindresorhus
Copy link
Owner

👍🏻

@Arnovsky Arnovsky deleted the empty-seperator branch July 18, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow empty replacement
2 participants
@Arnovsky @sindresorhus