improve exception handling #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgandhi1311
approved these changes
May 17, 2023
RushiT0122
requested changes
May 17, 2023
RushiT0122
requested changes
May 17, 2023
RushiT0122
reviewed
May 17, 2023
tap_mambu/helpers/client.py
Outdated
| raise MambuError(error) | ||
| except (ValueError, TypeError): | ||
| raise MambuError(error) | ||
| error_code = 500 if response.status_code > 500 else response.status_code |
There was a problem hiding this comment.
Are we treating all 500+ error codes as 500? That doesn't look like a correct approach.
There was a problem hiding this comment.
Yes,
Logically we are not altering the request based on any http status code (apart from retrying any exception that we come across) this will only be helpful for generating appropriate log statements, but i don't find it necessary to add more exception classes right now, as mambu has over 10,000 error codes, https://support.mambu.com/docs/api-response-error-codes, and those are not the http standard error codes.
RushiT0122
previously requested changes
May 17, 2023
somethingmorerelevant
dismissed
RushiT0122’s stale review
adding additional exception classes is not in the scope of this ticket, although they will be addressed in a different PR
RushiT0122
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps