Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle None values in HashableDict #109

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Handle None values in HashableDict #109

merged 3 commits into from
Jan 16, 2024

Conversation

bryantgray
Copy link
Contributor

Description of change

This change puts None values at the end of a list before the list is hashed.

Manual QA steps

  • Verified tap progresses through extraction when None values are present.

Risks

  • Low

Rollback steps

  • revert this branch

@bryantgray bryantgray merged commit f9f186b into master Jan 16, 2024
3 checks passed
@bryantgray bryantgray deleted the TDL-24626/Sort-None branch January 16, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsprayberry dsprayberry dsprayberry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryantgray @dsprayberry @cosimon