Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TDL-24743] Experiment various sync strategies for clients stream #111

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

shantanu73
Copy link
Contributor

@shantanu73 shantanu73 commented Jan 31, 2024

Description of change

The clients stream is missing many records in it's current incremental implementation so, it needs to be converted to full stream to accurately get all the relevant records.

  1. Converted clients stream from incremental to full table to get all records.
  2. Fixed integration tests.

Manual QA steps

  • Ran tap tester tests
  • Ran tap sync and observed records replicated in case of incremental and full table implementation of clients stream

Risks

  • low risk

Rollback steps

  • revert this branch

@sgandhi1311
Copy link
Member

Could you please add a detailed description to the pull request? It will be helpful in the future to understand why this change was made.

@sgandhi1311
Copy link
Member

Also, let's update the changes in the README.md file.

Copy link
Member

@sgandhi1311 sgandhi1311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looks good to me. Don't forget to bump the version. It will be major version bump, right?

@shantanu73 shantanu73 merged commit 9a5ae2d into master Feb 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants