Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singer io fix multipleof constraint failure #38

Merged
merged 13 commits into from
Mar 17, 2021

Conversation

jacobrobertbaca
Copy link
Contributor

Description of change

clone of #34

Manual QA steps

Risks

Rollback steps

  • revert this branch

@jacobrobertbaca jacobrobertbaca force-pushed the singer-io_fix-multipleof-constraint-failure branch from 6e53809 to 21c85ab Compare March 17, 2021 18:19
Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, and review for #34 looks good. :shipit:

@jacobrobertbaca jacobrobertbaca merged commit c8f1497 into master Mar 17, 2021
@jacobrobertbaca jacobrobertbaca deleted the singer-io_fix-multipleof-constraint-failure branch March 17, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants