-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Singer io fix multipleof constraint failure #38
Merged
jacobrobertbaca
merged 13 commits into
master
from
singer-io_fix-multipleof-constraint-failure
Mar 17, 2021
Merged
Singer io fix multipleof constraint failure #38
jacobrobertbaca
merged 13 commits into
master
from
singer-io_fix-multipleof-constraint-failure
Mar 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g re-process in the even of failure.
…to account for big decimal values received that were bigger than previous constraint.
… functionality to avoid a re-sync bug.
…figs when attempting a re-sync to avoid skipping over streams.
…oint configs when attempting a re-sync to avoid skipping over streams." This reverts commit b010d05.
…rent stream in selected_streams instead of iterating over items in endpoints dictionary.
jacobrobertbaca
force-pushed
the
singer-io_fix-multipleof-constraint-failure
branch
from
March 17, 2021 18:19
6e53809
to
21c85ab
Compare
dmosorast
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass, and review for #34 looks good.
This was referenced Mar 17, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
clone of #34
Manual QA steps
Risks
Rollback steps