-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/32 #66
Merged
Merged
Release/32 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s specific fixes and classes (WIP)
ECDDC-476 See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!7
ECDDC-476 Added record_count to refactor See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!9
…kback_window for the loan_transactions stream
…/32' [ECDDC-500] Lookback window bug fix See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!10
…'release/32'" This reverts merge request !10
…s specific fixes and classes (WIP)
…kback_window for the loan_transactions stream
…'release/32'" This reverts merge request !10
This reverts commit 96475ee.
…se/32' [ECDDC-519] Refactor loan repayments stream See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!11
… obtained by account_appraisal_date
…-date-bug' into 'release/32' Bugfix for records ignored when filtering by modified_date on records obtained See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!20
…ster tests, fixed schema
…-date-bug' into 'release/32' Bugfix/ecddc 559 release 32 fix loan accounts appraisal date bug See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!22
[ECDDC-570] Fix for missing journal lines See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!24
Hi @DownstreamDataTeam, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
dmosorast
approved these changes
Feb 11, 2022
You did it @DownstreamDataTeam! Thank you for signing the Singer Contribution License Agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added sorting to journal lines endpoint config, which fixes an extraction issue where the API would miss some records (due to sorting not being specified)
Manual QA steps
Risks
Rollback steps