Timezone improvement #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ECDDC-591] Fixed issue with users deduplication key See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!78
…' into 'release/40' [ECDDC-603] Added interest accrual breakdown stream See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!74
…se/40' [ECDDC-649] Added task_link_key field to tasks stream See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!75
[ECDDC-652] Adjusted Snyk dev test See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!67
…ease/40' [ECDDC-653] Finished implementing catalog automatic fields checker test See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!77
…b.com:mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu into feature/ECDDC-657_Refactor-audit-trail-stream
…nto 'release/40' [ECDDC-667] Added missing fields to loan_transaction's 'affected_amounts' object See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!81
…ease/40' [ECDDC-658] Refactor activities stream See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!79
added 6 commits
July 19, 2022 15:15
… into 'release/48' [ECDDC-724] Refactor timezone information system See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!125
…m-tap-processor' into 'release/48' [ECDDC-730] Decoupled Multithreading processor from TapProcessor See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!126
…counts-processor' into 'release/48' [ECDDC-737] Fixed Deduplication Processor PerformanceMetrics Bug See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!127
|
Hi @DownstreamDataTeam, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
… into 'release/48' [ECDDC-724] Fix for timezone system See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!128
[ECDDC-732] Merge master into release/48 See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!135
# Conflicts: # mambu_tests/conftest.py # mambu_tests/helpers.py # mambu_tests/multithreading/test_multithreaded_bookmark_daybyday_generator.py # mambu_tests/multithreading/test_multithreaded_bookmark_generator.py # mambu_tests/tap_generators/test_activities_generator.py # mambu_tests/tap_generators/test_groups_generator.py # mambu_tests/test_client.py # mambu_tests/test_sync.py # tap_mambu/helpers/multithreaded_requests.py # tap_mambu/sync.py # tap_mambu/tap_generators/activities_generator.py # tap_mambu/tap_generators/audit_trail_generator.py # tap_mambu/tap_generators/clients_generator.py # tap_mambu/tap_generators/communications_generator.py # tap_mambu/tap_generators/deposit_accounts_generator.py # tap_mambu/tap_generators/deposit_transactions_generator.py # tap_mambu/tap_generators/gl_journal_entries_generator.py # tap_mambu/tap_generators/groups_generator.py # tap_mambu/tap_generators/installments_generator.py # tap_mambu/tap_generators/interest_accrual_breakdown_generator.py # tap_mambu/tap_generators/loan_transactions_generator.py # tap_mambu/tap_generators/multithreaded_bookmark_generator.py # tap_mambu/tap_processors/deduplication_processor.py # tap_mambu/tap_processors/multithreaded_parent_processor.py # tap_mambu/tap_processors/processor.py
Solved conflicts between release/48 and master branch See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!137
DownstreamDataTeam
force-pushed
the
release/48
branch
from
0bc40d4 to
6204529
Compare
added 4 commits
September 14, 2022 19:21
Sync Master with release/48 See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!139
[ECDDC-756] Bugfix: Added missing date formats See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!140
bryantgray
reviewed
Sep 20, 2022
|
|
||
|
|
||
| def datetime_to_local_str(dttm: datetime) -> str: | ||
| return dttm.astimezone(_timezone).strftime("%Y-%m-%dT%H:%M:%S.%fZ") |
There was a problem hiding this comment.
This will leave the local time in the format 2022-09-20T14:10:24.865664Z. This returns the correct local time, but the Z at the end implies UTC time. Adding %z to the end of the time format will add the offset to the UTC time, which seems to be the intended return value. The ISO-8601 format would be %Y-%m-%dT%H:%M:%S.%f%z This would make the return value 2022-09-20T14:10:24.865664-0400 when using US/Eastern as the timezone.
bryantgray
approved these changes
Sep 27, 2022
Merged
|
You did it @DownstreamDataTeam! Thank you for signing the Singer Contribution License Agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Rollback steps