Missing time_extracted field #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 5, 2022 18:48
…ease/54' [ECDDC-763] Downgraded the timezone endpoint from v2 to v1 See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!142
Sync between master and release/54 See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!143
[ECDDC-762] Fixed missing time_extracted field See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!144
|
Hi @DownstreamDataTeam, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
bryantgray
approved these changes
Oct 11, 2022
Merged
|
Hi,
We have an unmarked PR since more than 4 months. Could you tell us what is the problem there?
Thanks.
… On 12 Oct 2022, at 21:24, 'bryantgray' via Ecosystem Downstream Data ***@***.***> wrote:
Merged #98 <#98> into master.
—
Reply to this email directly, view it on GitHub <#98 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUFIALLLKLTDWR7YRBT5C43WC364HANCNFSM6AAAAAARCHS25I>.
You are receiving this because you were mentioned.
|
|
You did it @DownstreamDataTeam! Thank you for signing the Singer Contribution License Agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
For multithreaded classes, the time_extracted field wasn't populated.
We've changed the location (only for multithreading) where that field was populated, moving the assignment from generator to processor, right before the record is written in the stdout.
Rollback steps