TDL-16139 Support of service account authentication #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbshah1212
reviewed
Oct 7, 2022
dbshah1212
approved these changes
Oct 10, 2022
savan-chovatiya
approved these changes
Oct 11, 2022
kethan1122
changed the base branch from
TDL-20804-format-code-with-standard-formatters
to
master
RushiT0122
reviewed
Jun 19, 2023
RushiT0122
reviewed
Jun 19, 2023
RushiT0122
reviewed
Jun 19, 2023
RushiT0122
reviewed
Dec 1, 2023
Comment on lines
+42
to
+44
| with self.assertRaises(Exception) as e: | ||
| with MixpanelClient(None, None, None, None,"api_domain", 300) as client_: | ||
| pass |
There was a problem hiding this comment.
Suggested change
| with self.assertRaises(Exception) as e: | |
| with MixpanelClient(None, None, None, None,"api_domain", 300) as client_: | |
| pass | |
| with self.assertRaises(Exception) as e: | |
| MixpanelClient(None, None, None, None,"api_domain", 300) |
RushiT0122
reviewed
Dec 1, 2023
Comment on lines
+17
to
+19
| """ | ||
| with MixpanelClient("api_secret", None, None, None,"api_domain", 300) as client_: | ||
| pass |
There was a problem hiding this comment.
Suggested change
| """ | |
| with MixpanelClient("api_secret", None, None, None,"api_domain", 300) as client_: | |
| pass | |
| MixpanelClient("api_secret", None, None, None,"api_domain", 300) |
RushiT0122
reviewed
Dec 1, 2023
Comment on lines
+28
to
+30
| mock_check_access: Mock the check_access method to test authentication. | ||
| """ | ||
| with MixpanelClient(None, "service_account_username", "service_account_secret", "project_id","api_domain", 300, auth_type="saa") as client_: |
There was a problem hiding this comment.
Suggested change
| mock_check_access: Mock the check_access method to test authentication. | |
| """ | |
| with MixpanelClient(None, "service_account_username", "service_account_secret", "project_id","api_domain", 300, auth_type="saa") as client_: | |
| MixpanelClient(None, "service_account_username", "service_account_secret", "project_id","api_domain", 300) |
RushiT0122
reviewed
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
service_account_usernameservice_account_secretproject_idNote: Currently, the build is failing because config parameters for the service account authentication are not added in the UI.
Manual QA steps
Risks
Rollback steps