[TDL-25850] Add backoff for client error 406 #181
+49
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantanu73
changed the title
sgandhi1311
reviewed
Jun 3, 2024
| main() | ||
|
|
||
| # verify "LOGGER.critical" is called once | ||
| self.assertEqual(mocked_logger_critical.call_count, 1) |
There was a problem hiding this comment.
Please verify if the retry count exceeds 1. Note that within the tap code, the maximum retry limit is configured to 10.
|
The changes look good to me. Can we get the integration test fixed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
QA steps
Risks
Rollback steps