Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log message #66

Closed
andre-senna opened this issue Dec 13, 2023 · 0 comments · Fixed by #74
Closed

Improve log message #66

andre-senna opened this issue Dec 13, 2023 · 0 comments · Fixed by #74
Assignees

Comments

@andre-senna
Copy link
Contributor

andre-senna commented Dec 13, 2023

 raise RetryException(
hyperon_das.exceptions.RetryException: ('The number of attempts has been exceeded or a timeout has occurred', {'attempts': 5, 'time': '100 seconds'})

The name of this exception is terrible and the message itself is not particularly useful. The name is misleading because it's saying that there's a problem related to retry but that's not the case. The real problem is that it's not being able to connect. So it should be something like ConnectionError or something alike.

As for the information, we should provide here every piece of useful information from the context. The obvious ones being host and port number that were tried. There is probably more to add so please take a careful look at the code and think about what would we want to be there if we only have this exception to debug a reported error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants