Fix stub.withArgs(args...) is incorrect

Change last pop to the most matched arguments at stub.
sinonjs · Jun 28, 2017 · f012fff · f012fff
1 parent 76ac773
commit f012fff
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/lib/sinon/stub.js b/lib/sinon/stub.js
@@ -90,7 +90,15 @@ var proto = {
             var args = slice.call(arguments);
             var matchings = functionStub.matchingFakes(args);
 
-            var fnStub = (matchings && matchings.pop()) || functionStub;
+            var fnStub;
+            if (matchings) {
+                fnStub = matchings.sort(function (a, b) {
+                    return a.matchingArguments.length - b.matchingArguments.length;
+                }).pop();
+            }
+            if (!fnStub) {
+                fnStub = functionStub;
+            }
             return getCurrentBehavior(fnStub).invoke(this, arguments);
         };