Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure unique exp names #48

Merged
merged 8 commits into from
Aug 3, 2021
Merged

Ensure unique exp names #48

merged 8 commits into from
Aug 3, 2021

Conversation

zeehio
Copy link
Member

@zeehio zeehio commented Jun 12, 2021

Closes #44

zeehio added 8 commits June 11, 2021 20:16
@zeehio
Fix PCA scores and loadings.
65d3e36 
The pca building function uses mixOmics::pca, not stats::prcomp, so the loadings are in $loadings$X and the scores at $X
@zeehio
Fix array compatibility issues from R 4.0
3add52d 
Use purrr::map instead of vapply for readability

Update demo dataset so issue sipss#46 is tested

Closes sipss#46
@zeehio
Try fixing scores plot
6bc9e20
@zeehio
Ensure NMRExperiment names are unique
469b28b 
Closes sipss#44
@zeehio
Add vctrs as direct dependency
2ae8058 
It already existed as an indirect one
@zeehio
Fix typo syntax error
4da62ad
@zeehio
Test for unique NMRExperiment
a78067f 
Test for unique NMRExperiment values
@zeehio
Fix test
f1130b0
@codecov
Copy link

codecov bot commented Jun 12, 2021

Codecov Report

Merging #48 (f1130b0) into master (8463caf) will increase coverage by 0.17%.
The diff coverage is 76.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   42.68%   42.85%   +0.17%     
==========================================
  Files          29       29              
  Lines        3341     3330      -11     
==========================================
+ Hits         1426     1427       +1     
+ Misses       1915     1903      -12
Impacted Files Coverage Δ
R/nmr_data_analysis.R 22.78% <0.00%> (ø)
R/bruker.R 50.54% <66.66%> (+2.27%) ⬆️
R/nmr_dataset.R 64.44% <78.33%> (-1.36%) ⬇️
R/pca_helpers.R 95.34% <100.00%> (+0.08%) ⬆️
R/utils.R 95.18% <100.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8463caf...f1130b0. Read the comment docs.

@zeehio zeehio merged commit 13e84d6 into sipss:master Aug 3, 2021
@philibe philibe mentioned this pull request Apr 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory usage
1 participant
@zeehio