Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dep.netty.version from 4.0.49.Final to 4.1.51.Final in /java #5

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Jul 21, 2020

Bumps dep.netty.version from 4.0.49.Final to 4.1.51.Final.
Updates netty-handler from 4.0.49.Final to 4.1.51.Final

Commits
  • 646934e [maven-release-plugin] prepare release netty-4.1.51.Final
  • cb9d4a1 Correctly return NEED_WRAP if we produced some data even if we could not cons...
  • e04803d Modify OpenSSL native library loading to accommodate GraalVM (#10395)
  • 39928e3 Update to netty-tcnative 2.0.31.Final and make SslErrorTest more robust (#10392)
  • 9557c88 Add option to HttpObjectDecoder to allow duplicate Content-Lengths (#10349)
  • 7a05aa1 Add detailed error message corresponding to the IndexOutOfBoundsException whi...
  • 9893ac7 Do not report ReferenceCountedOpenSslClientContext$ExtendedTrustManagerVerify...
  • a608437 Add unit test for HpackDynamicTable. (#10389)
  • cbe238a Correctly include TLS1.3 ciphers in the enabled ciphersuites when using Borin...
  • 523dc5c Fix #10378,ResourceLeakDetectorFactory.newResourceLeakDetector(Class, int) ig...
  • Additional commits viewable in compare view

Updates netty-buffer from 4.0.49.Final to 4.1.51.Final

Commits
  • 646934e [maven-release-plugin] prepare release netty-4.1.51.Final
  • cb9d4a1 Correctly return NEED_WRAP if we produced some data even if we could not cons...
  • e04803d Modify OpenSSL native library loading to accommodate GraalVM (#10395)
  • 39928e3 Update to netty-tcnative 2.0.31.Final and make SslErrorTest more robust (#10392)
  • 9557c88 Add option to HttpObjectDecoder to allow duplicate Content-Lengths (#10349)
  • 7a05aa1 Add detailed error message corresponding to the IndexOutOfBoundsException whi...
  • 9893ac7 Do not report ReferenceCountedOpenSslClientContext$ExtendedTrustManagerVerify...
  • a608437 Add unit test for HpackDynamicTable. (#10389)
  • cbe238a Correctly include TLS1.3 ciphers in the enabled ciphersuites when using Borin...
  • 523dc5c Fix #10378,ResourceLeakDetectorFactory.newResourceLeakDetector(Class, int) ig...
  • Additional commits viewable in compare view

Updates netty-common from 4.0.49.Final to 4.1.51.Final

Commits
  • 646934e [maven-release-plugin] prepare release netty-4.1.51.Final
  • cb9d4a1 Correctly return NEED_WRAP if we produced some data even if we could not cons...
  • e04803d Modify OpenSSL native library loading to accommodate GraalVM (#10395)
  • 39928e3 Update to netty-tcnative 2.0.31.Final and make SslErrorTest more robust (#10392)
  • 9557c88 Add option to HttpObjectDecoder to allow duplicate Content-Lengths (#10349)
  • 7a05aa1 Add detailed error message corresponding to the IndexOutOfBoundsException whi...
  • 9893ac7 Do not report ReferenceCountedOpenSslClientContext$ExtendedTrustManagerVerify...
  • a608437 Add unit test for HpackDynamicTable. (#10389)
  • cbe238a Correctly include TLS1.3 ciphers in the enabled ciphersuites when using Borin...
  • 523dc5c Fix #10378,ResourceLeakDetectorFactory.newResourceLeakDetector(Class, int) ig...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps `dep.netty.version` from 4.0.49.Final to 4.1.51.Final.

Updates `netty-handler` from 4.0.49.Final to 4.1.51.Final
- [Release notes](https://github.com/netty/netty/releases)
- [Commits](netty/netty@netty-4.0.49.Final...netty-4.1.51.Final)

Updates `netty-buffer` from 4.0.49.Final to 4.1.51.Final
- [Release notes](https://github.com/netty/netty/releases)
- [Commits](netty/netty@netty-4.0.49.Final...netty-4.1.51.Final)

Updates `netty-common` from 4.0.49.Final to 4.1.51.Final
- [Release notes](https://github.com/netty/netty/releases)
- [Commits](netty/netty@netty-4.0.49.Final...netty-4.1.51.Final)

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 21, 2020
GeorgeAp pushed a commit that referenced this pull request Jun 7, 2021
From a deadlocked run...

```
#0  0x00007f8a5d48dccd in __lll_lock_wait () from /lib64/libpthread.so.0
#1  0x00007f8a5d486f05 in pthread_mutex_lock () from /lib64/libpthread.so.0
#2  0x00007f8a566e7e89 in arrow::internal::FnOnce<void ()>::FnImpl<arrow::Future<Aws::Utils::Outcome<Aws::S3::Model::ListObjectsV2Result, Aws::S3::S3Error> >::Callback<arrow::fs::(anonymous namespace)::TreeWalker::ListObjectsV2Handler> >::invoke() () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so
#3  0x00007f8a5650efa0 in arrow::FutureImpl::AddCallback(arrow::internal::FnOnce<void ()>) () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so
#4  0x00007f8a566e67a9 in arrow::fs::(anonymous namespace)::TreeWalker::ListObjectsV2Handler::SpawnListObjectsV2() () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so
#5  0x00007f8a566e723f in arrow::fs::(anonymous namespace)::TreeWalker::WalkChild(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int) () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so
#6  0x00007f8a566e827d in arrow::internal::FnOnce<void ()>::FnImpl<arrow::Future<Aws::Utils::Outcome<Aws::S3::Model::ListObjectsV2Result, Aws::S3::S3Error> >::Callback<arrow::fs::(anonymous namespace)::TreeWalker::ListObjectsV2Handler> >::invoke() () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so
#7  0x00007f8a5650efa0 in arrow::FutureImpl::AddCallback(arrow::internal::FnOnce<void ()>) () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so
#8  0x00007f8a566e67a9 in arrow::fs::(anonymous namespace)::TreeWalker::ListObjectsV2Handler::SpawnListObjectsV2() () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so
#9  0x00007f8a566e723f in arrow::fs::(anonymous namespace)::TreeWalker::WalkChild(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int) () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so
#10 0x00007f8a566e74b1 in arrow::fs::(anonymous namespace)::TreeWalker::DoWalk() () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so
```

The callback `ListObjectsV2Handler` is being called recursively and the mutex is non-reentrant thus deadlock.

To fix it I got rid of the mutex on `TreeWalker` by using `arrow::util::internal::TaskGroup` instead of manually tracking the #/status of in-flight requests.

Closes apache#9842 from westonpace/bugfix/arrow-12040

Lead-authored-by: Weston Pace <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Feb 16, 2022

Looks like these dependencies are up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Feb 16, 2022
@dependabot dependabot bot deleted the dependabot/maven/java/dep.netty.version-4.1.51.Final branch February 16, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants