linspace -> range #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes deprecated linspace in favor of range. See example here: JuliaPy/PyCall.jl#518
|
Why did you close it? Should I merge it? There is also |
range -> LinRange
|
I closed it initially because I realized that range didn't work in this case, was experimenting with LinRange locally 👍 |
|
Does this work now? If you have written some tests locally maybe you can integrate to the tests in runtests.jl ? I think in the close future we should move the lidar functionality to https://github.com/sisl/AutomotiveSensors.jl One of the biggest issue of AutomotiveDrivingModels.jl is that the repository is too big. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes deprecated linspace in favor of range.
See example here: JuliaPy/PyCall.jl#518