Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor ui nitpicks #62

Closed
WasabiPizza opened this issue Jan 9, 2021 · 6 comments · Fixed by #72
Closed

minor ui nitpicks #62

WasabiPizza opened this issue Jan 9, 2021 · 6 comments · Fixed by #72
Labels
bug Something isn't working

Comments

@WasabiPizza
Copy link

Hi, first of all thank you for making linkding! I've been looking for a while for a selfhosted alternative to pinboard.in and I think I finally found one.

I just wanted to comment on two minor issues:

  1. The search bar and button on mobile don't look like they do on desktop, is this intentional? Because it doesn't look good in my opinion.
  2. Always on mobile, the hamburger menu can't be closed once it has been opened. I have to click on a link or on the search bar to hide it.

Thanks!

@sissbruecker
Copy link
Owner

@WasabiPizza Thanks for reporting this, I'll definitely look at this when I find the time. Meanwhile, can you please elaborate on 1., maybe with a screenshot on your device? Personally I can not see any issue when using dev tools or my mobile device.

@WasabiPizza
Copy link
Author

Sorry I should have added a screenshot in the first place. Anyway here’s how it looks on my iPhone on Safari, strangely if I choose responsive in the dev tools the search bar looks fine.

3178A0E2-EB6B-4752-A3B6-F32BB48E0975

@sissbruecker
Copy link
Owner

Thanks, looks like mobile Safari has some very specific opinions on how <input type="search"> should be displayed. I think I'll change it to a regular input and add some aria role instead.

@sissbruecker sissbruecker added the bug Something isn't working label Feb 6, 2021
sissbruecker pushed a commit that referenced this issue Feb 6, 2021
* Fix mobile Safari searchbox style (#62)

* Fix mobile menu not closing on outside click (#62)
@sissbruecker
Copy link
Owner

Fixed the searchbox styles and added Javascript for closing the mobile dropdown menu in case the browser does not trigger blur events on outside clicks.

@WasabiPizza
Copy link
Author

Thank you! I have just updated and the search box looks very nice now!

Not sure about the menu though, now it can be closed by tapping anywhere on the screen but the menu itself. Not sure if it is the indented behavior but I guess reporting it doesn’t hurt.

@sissbruecker
Copy link
Owner

@WasabiPizza You're welcome 🙂. Yes the menu behaviour is intented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants