Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titles show before animation #146

Closed
kenumir opened this issue Dec 11, 2018 · 7 comments
Closed

Titles show before animation #146

kenumir opened this issue Dec 11, 2018 · 7 comments

Comments

@kenumir
Copy link

kenumir commented Dec 11, 2018

Describe the bug
Labels (PrimaryText, SecondaryText) show before animation, hides and show with animation again.

To Reproduce
Video https://www.youtube.com/watch?v=8XRp8cZHN9o watch in slow mode ;-)

Smartphone (please complete the following information):

  • Device: Nexus 6
  • OS: Android 7.1.1
  • Library version 2.14.0
@poojagarje
Copy link

I'm also facing same issue

@iljaosintsev
Copy link

@sjwall apply patch for fix it?

@danilodanicomendes
Copy link
Contributor

I know this is old, but we stumbled on the same issue. It is more visible when the background is not mainly white.

The animation can be improved by using a mode of PorterDuff this way it clips the text that does not have the circle background under it yet. See the below animations to see the differences.

Current (it even glitches the text because PromptText.prepare is setting 1 as default for alpha):

current.mp4

Proposal:

proposal.mp4

If you want, I can open a PR. It's a simple change.

@sjwall
Copy link
Owner

sjwall commented Nov 1, 2021

@danilodanicomendes yes please do open a PR for it, will be much appriciated

danilodanicomendes added a commit to danilodanicomendes/MaterialTapTargetPrompt that referenced this issue Nov 3, 2021
* Add Xfer mode to paint, so the text pixels are only drawn when the background reaches them.
sjwall pushed a commit that referenced this issue Nov 6, 2021
* Add Xfer mode to paint, so the text pixels are only drawn when the background reaches them.
@sjwall
Copy link
Owner

sjwall commented Nov 6, 2021

The fix for this has been released in v3.3.1

@sjwall sjwall closed this as completed Nov 6, 2021
@danilodanicomendes
Copy link
Contributor

Glad to help. Keep up the good work :)

@peterdk
Copy link
Contributor

peterdk commented Nov 6, 2021

I was looking for this bug to fix it, but saw a fix already in place. Nice!
However, I am facing now a weird regression due to upgrade 3.3.0 -> 3.3.1.
Colors of the text now blend with the background, making my help texts unreadable.
3 3 0
3 3 1

Is this due to the Xfer mode? Or is it a other change in the library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants