Do not invoke view details callback on notifications without links

skateman · Sep 13, 2018 · 4875c5f · 4875c5f
1 parent f586c32
commit 4875c5f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/app/assets/javascripts/controllers/notifications/notifications_drawer_controller.js b/app/assets/javascripts/controllers/notifications/notifications_drawer_controller.js
@@ -116,10 +116,6 @@ function NotificationsDrawerCtrl($scope, eventNotifications, $timeout) {
     eventNotifications.markRead(notification, group);
   };
 
-  vm.customScope.viewSubjectDetails = function(notification) {
-    eventNotifications.viewDetails(notification);
-  }
-
   vm.customScope.clearNotification = function(notification, group) {
     eventNotifications.clear(notification, group);
   };

diff --git a/app/views/static/notification_drawer/notification-body.html.haml b/app/views/static/notification_drawer/notification-body.html.haml
@@ -8,7 +8,7 @@
       %span.fa.fa-ellipsis-v
     %ul.dropdown-menu.dropdown-menu-right{'aria-labelledby' => 'dropdownKebabRight-{{ notification.id }}'}
       %li{:role => 'menuitem', 'ng-class' => "{'disabled': !notification.data.link}"}
-        %a.secondary-action{:title => _('View details'), 'ng-click' => 'customScope.viewSubjectDetails(notification)'}
+        %a.secondary-action{:title => _('View details'), 'ng-click' => 'notification.actionCallback(notification)'}
           = _('View details')
       %li.divider{:role => 'separator'}
       %li{:role => 'menuitem', 'ng-class' => "{'disabled': !notification.unread}"}