Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mode A: Twitter Slider #421

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Mode A: Twitter Slider #421

wants to merge 4 commits into from

Conversation

alexspyr
Copy link
Contributor

Twitter Slider Component with demo tweets.

library used is http://kenwheeler.github.io/slick/

Had to add the following line on the footer on _layouts/default.html in order to make it work.

<script type="text/javascript" src="https://cdn.jsdelivr.net/gh/kenwheeler/[email protected]/slick/slick.min.js"></script>

For sure there is a better way to do it. (eg: creating a custom layout file so it doesn't load on all pages )

@alexspyr alexspyr requested a review from kbariotis January 31, 2019 17:43
@varemenos
Copy link
Contributor

Would you mind formatting/prettify the changes? (Check the diff of this pull request, you will notice a lot of empty lines, unindented code etc).

Can you explain what this page does? Is there is a particular reason why it's named like this? It doesn't seem very user friendly. pages/working/a.html (or is this just a demostrative PR?)

Check your yarn.lock file, it's not fully merged so it has traces of unmerged code.

Also, there are some commented out cdn files included, do we need those or can they be removed?

@@ -79,6 +71,8 @@ ajv-keywords@^3.1.0:
resolved "https://registry.yarnpkg.com/ajv-keywords/-/ajv-keywords-3.1.0.tgz#ac2b27939c543e95d2c06e7f7f5c27be4aa543be"
integrity sha1-rCsnk5xUPpXSwG5/f1wnvkqlQ74=

<<<<<<< HEAD
Copy link
Contributor

@varemenos varemenos Jan 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like something went wrong here, did you try to merge before you started working on this feature?
Were there supposed to be any changes in the yarn.lock file? if not and you don't know how to fix it, let me know and I will help you out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants