Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

saying invalid username and/or password #42

Closed
jkawamoto4 opened this issue Feb 10, 2021 · 40 comments
Closed

saying invalid username and/or password #42

jkawamoto4 opened this issue Feb 10, 2021 · 40 comments
Labels
bug Something isn't working

Comments

@jkawamoto4
Copy link

I am trying to login to milkshake and it keeps telling me invalid username/password but it is not wrong as I was already logged in earlier in the day. I have reset my password with pandora and it still is not working. I have uninstalled the app and reinstalled it and it is still giving me this error. not really sure what do from here, thanks.
@loupgrru
Copy link

Same thing here. Started yesterday.

@rmw1221
Copy link

rmw1221 commented Feb 10, 2021

Same issue here as well... discovered today

@dauhrman
Copy link

Same issue. Started today. Name and password still work on Pandora website. Deleted and redownloaded from Apple App Store, new copy picked up same credentials from my computer, still refused to validate. Tried multiple times to manually input to no avail.

@sygibson
Copy link

sygibson commented Feb 10, 2021 •
edited
Loading

I can confirm that on Tue Feb 9 2021 in the afternoon (PST) - my Milkshake app also can no longer login. Receiving the same Invalid username and/or password error.

I verified I can log in to my Pandora account from the miserable P.O.S. Mac app that Pandora makes, and via the web page.

In fact - I'm listening to Pandora in a Safari browser window after successfully logging in ... as I write this.

@afterthetone
Copy link

Discovered same thing today. This is still an issue.

@ReallyRandy
Copy link

Same here. Pandora must have changed something in their API.

@eric997tt
Copy link

Delete your password and sign in. I'm not sure why it works, but I deleted my password and accidentally clicked "login" and it started working.

@ReallyRandy
Copy link

Delete your password and sign in. I'm not sure why it works, but I deleted my password and accidentally clicked "login" and it started working.

Wow, that worked, Thanks!

@dauhrman
Copy link

Removing password worked! Still needs to be fixed, but this will do for now.

Thanks much.

@loupgrru
Copy link

Fortuitous mistakes for the win! Thanks, Eric.

Closed
@loupgrru
Copy link

It stopped working again. Going without a password is no longer letting me in. Anyone else having this problem?

@dauhrman
Copy link

dauhrman commented Feb 24, 2021 via email

@z4am
Copy link

z4am commented Sep 3, 2021

Just a note that as of today, deleting your password still works. First try to sign in with your password, then delete it and log in.
One of these days I'll learn some Swift so I can get the volume, crossfade, and spectrum settings to persist, but still one of my favorite apps.

@loupgrru
Copy link

loupgrru commented Sep 4, 2021

I had deleted it after it stopped working. I just tried to reinstall after seeing z4am’s comment, but apparently it’s no longer available, or at least not in the US.

@z4am
Copy link

z4am commented Sep 6, 2021

Hi @loupgrru, the .DMG installer is still available right here https://github.com/skiptomyliu/milkshake
To test it, I just downloaded and installed it on my son's Macbook and logged in successfully. :)

@loupgrru
Copy link

loupgrru commented Sep 11, 2021 via email

@djames42
Copy link

FWIW, this trick no longer seems to work. I've tried it on both my Macs and have also tried deleting the app and associated preference and container data.

Would love to fork this and get it working again - I love the small footprint and the crossfade - but I just don't have time right now.

@djames42
Copy link

Well bad news. Looks like the developer token used by the app has expired and needs to be renewed. When I step through the code, I'm seeing the following response from Pandora when I attempt to authenticate:
"message" : "Auth Token is Expired - ...[token hidden here, even though it's available in the source code]"

I tried to register a new developer account with Pandora so I could generate a new token, but they're not accepting new requests at this time. At this point, only the original developer can sort this out and he's gone MIA from this project so I don't see that likely happening. It seems a bit silly that Pandora would expire an application token that would require a number of apps to be redistributed in order to function again. But it also looks like Pandora may be moving from a direct username/password login to an end-user token authentication so they may have deprecated these legacy Auth Tokens on purpose to force developers into updating their code.

It seems like the reason this was working for a period of time with a blank password is that a cookie was stored locally that eliminated the need to authenticate every time the app was launched. When those cookies expired, the app would fall back to authenticating and fail due to the expired Auth Token.

@loupgrru
Copy link

loupgrru commented Dec 21, 2021 via email

@skiptomyliu
Copy link
Owner

skiptomyliu commented Dec 30, 2021 •
edited
Loading

@djames42 @loupgrru

Thanks for helping dig here. I took a look this afternoon and it looks like Pandora made some changes into their login REST API. The tl;dr is, there are additional fields that are required during login where I cannot grok exactly how it's being generated. Almost like a CSRF token. Omitting these fields makes the login fail.

There's an unofficial Pandora API doc here: https://6xq.net/pandora-apidoc/json/

Note that there are two APIs, a REST API and a JSON API v5. Milkshake was using the REST API which is what the browser uses as well.

What needs to happen is to migrate auth to the JSON API v5 instead. I'm unsure exactly if that is the only thing that needs to be done and if the token generated by the JSON API can be used with the REST API. Either way, I'll take a look but hope to have a update with what I find.

@skiptomyliu
Copy link
Owner

Bummer -- so it looks like Pandora added some anti bot measures which is why this has been breaking. Migrating to the JSON API v5 API would be needed. However, unfortunately I can't commit to it at this time. :\

Dropping some rough notes for myself (and potentially others if they want to dig in).

  1. Login as partner https://6xq.net/pandora-apidoc/json/partners/#partners using the partner password: https://6xq.net/pandora-apidoc/json/partners/#android

  2. Using the auth token generated, then login as a user: https://6xq.net/pandora-apidoc/json/authentication/#user-login

The generated token seems to work with the JSON API based on reports from PromyLOPh/pandora-apidoc#45

The heavy lift for this change is introducing CryptoSwift into the project so we can encrypt the payloads for the user login.

@djames42 djames42 mentioned this issue Jun 7, 2022
Closed
@skiptomyliu
Copy link
Owner

skiptomyliu commented Aug 10, 2022 •
edited
Loading

I'm working on a fix. This PR is working #45 and contains an updated dmg install with the fix.

Cleaning up some things before I merge. Aiming for EOW.

@skiptomyliu skiptomyliu mentioned this issue Aug 10, 2022
Merged
@skiptomyliu skiptomyliu added the bug Something isn't working label Aug 10, 2022
@skiptomyliu
Copy link
Owner

v1.1.0 fix has finally been released to the appstore:
https://apps.apple.com/us/app/milkshake-player-for-pandora/id1440379601?mt=12

v1.1.1 it's also available for download which fixes the search results:
https://github.com/skiptomyliu/milkshake/releases

I'll push another round of fixes to the appstore soon. Thanks immensely for being incredibly patient on this. Hoping to finally start doing releases on a more regular cadence.

@djames42
Copy link

This is brilliant! Thank you so much for taking the time to resolve the login issue.

I love that this is open source, but honestly I would've happily paid for this app. I use it all day, every day. Maybe a paid iOS version?

@loupgrru
Copy link

loupgrru commented Aug 11, 2022 via email

@skiptomyliu
Copy link
Owner

This is brilliant! Thank you so much for taking the time to resolve the login issue.

I love that this is open source, but honestly I would've happily paid for this app. I use it all day, every day. Maybe a paid iOS version?

@djames42 thanks for the very kind words! I love Pandora and building things, happy to share something that ya'll enjoy!

Keeping it free keeps it as a hobby and the stress levels down 😂

@feego16
Copy link

feego16 commented Oct 23, 2023

its not working when I log in my email or password.

@feego16
Copy link

feego16 commented Oct 23, 2023

How is it working for you guys?

@djames42
Copy link

How is it working for you guys?

I just tried it and it's working fine for me.

@feego16
Copy link

feego16 commented Oct 23, 2023

how did you get it to work? I tried to put in my email and password and its not working.

@feego16
Copy link

feego16 commented Oct 23, 2023

Screenshot 2023-10-23 at 12 47 18 PM

@feego16
Copy link

feego16 commented Oct 23, 2023

I logged into Pandora ok but when I try to log in milkshake its not logging me in.

@djames42
Copy link

Odd. my login info was prepopulated from prior logins. I clicked the Login button and got my list of stations, which play just fine.

@feego16
Copy link

feego16 commented Oct 23, 2023

How did you get those loggins? I used the login I created years ago. How do u populate loggins? Im not good at coding so I'm not sure if its a code thing.

@feego16
Copy link

feego16 commented Oct 23, 2023 •
edited
Loading

Is there a special password I should enter for mine to work? I don't know what I am doing wrong.

@djames42
Copy link

No code thing. The login and password are the same that you would use to log in directly to Pandora. The credentials are saved after logging in so now all I need to do is click the login button.

I'm not sure why your login isn't working. If I have time, I will launch a MacOS virtual machine and try logging in fresh to see if my credentials work okay for an initial login.

@djames42
Copy link

I had a VM all ready to go so I just tried logging in fresh. When this issue first cropped up, my existing login credentials worked for a time but I was unable to log in with a new install. I thought maybe a similar issue might be happening.

Alas, I downloaded the Milkshake DMG from here into the VM, launched the app, and manually typed my login credentials and it worked okay. Perhaps there are characters in your password the app isn't able to pass through the API okay, but otherwise I can't fathom why your login works on the web but not in the app.

@feego16
Copy link

feego16 commented Oct 23, 2023

I am not using the app from the appstore. Im using the one from this github. I don't know why mine isn't working. I deleted and downloaded it twice and still nothing. It used to work with no password until it stopped working again. I read ur past messages and noticed its working for u guys and then I downloaded it again and entered both email and password but still nothing.

@djames42
Copy link

I also use the version from Github. I would normally suggest deleting the application preference file from either ~/Library/Preferences or ~/Library/Application Support but it appears Milkshake does not use this. Looking at the code, it pulls the login and password from the Keychain, so you might quit Milkshake, launch Keychain Access, search for Milkshake, and delete that entry. Then close Keychain and relaunch Milkshake and enter your Pandora login and password again.

I suspect this will not do anything, but I cannot think of what else to try.

@feego16
Copy link

feego16 commented Oct 24, 2023

its working now. It seems I have to use a VPN thanks for ur time tho I really appreciate u trying to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests