Add ProgramFlow-Visualization plugin #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains the work of Marko Velten, Matthias Reichenbach and me. The integration should work. However, the visualization and trace generation itself has a lot of bugs left that still need to be fixed.
The new version of TypeScript does no longer seem to be compatible with Node.js 12.
This allows us to not rely on the assumption that "<string>" is always representing the filename of the main file. This led to problems in the skipping logic where some code executed through an import statement was assumed to be our code. That led to stack frames being popped (which shouldn't be popped at that point).
Strings are displayed on the stack again.
This can otherwise cause all sorts of issues. Also, the internals of the generator object are not that important for beginners.
skogsbaer
reviewed
Oct 2, 2024
This avoids mixing up the program's stdout with the trace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration of the (formerly separate) visualization plugin should work. However, the visualization and trace generation itself have a lot of bugs left that still need to be fixed.
If you're fine with testing this out on a branch, we can leave this pull request open and merge it just right before the release of the new plugin version.