Address a couple of Python SyntaxWarnings. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running uncalled with Python 3.13 raises a couple of syntax warning,
reproducible for instance by running the example script:
$ cd example
$ ./run_example.sh
/usr/bin/uncalled:307: SyntaxWarning: invalid escape sequence '\-'
log_re = re.compile("^([0-9\-]+ [0-9:]+).+ :.+instance_started.+")
/usr/bin/uncalled:308: SyntaxWarning: invalid escape sequence '\d'
port_re = re.compile("grpc_port = (\d+)")
/usr/bin/uncalled:309: SyntaxWarning: invalid escape sequence '\s'
device_re = re.compile("(device_id|instance) = ([^\s,]+)")
[…]
In addition, [Debian bug #1087156] reported also another instance of
the issue in the debug.py script:
Setting up uncalled (2.3+ds-2) ...
/usr/lib/python3/dist-packages/uncalled/debug.py:23: SyntaxWarning: invalid escape sequence '\d'
CIG_RE = re.compile("(\d+)(["+CIG_OPS_STR+"])")
This change adjusts strings to become raw strings, in order to spare
Python further attempts to interpret backslashed characters as escape
sequences that are invalid.
[Debian bug #1087156]: https://bugs.debian.org/1087156
Signed-off-by: Étienne Mollier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running uncalled with Python 3.13 raises a couple of syntax warning, reproducible for instance by running the example script:
In addition, Debian bug #1087156 reported also another instance of the issue in the debug.py script:
This change adjusts strings to become raw strings, in order to spare Python further attempts to interpret backslashed characters as escape sequences that are invalid.