Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages for missing required keys #10

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

alexkalderimis
Copy link
Contributor

More specific messages for required keys

Improves the error messages when required keys are missing, by listing precisely
which ones are missing.

Also:

  • improves dev experience by allowing use of debugger by default
  • improves editor experience by improving rubocop integrations

@alexkalderimis
Copy link
Contributor Author

I removed the offending debug dev dependency, so as not to break jruby and truffleruby.

This should be ready for review.

@alexkalderimis
Copy link
Contributor Author

Thanks for your reactions @skryukov - could I ask you for a review and release of a new version? Would you like me to update this branch to bump the version?

@skryukov
Copy link
Owner

@alexkalderimis it's fine as it is, I'll release a new version later today 👍

@skryukov skryukov merged commit 137058e into skryukov:main Oct 31, 2024
7 checks passed
@skryukov
Copy link
Owner

Released in 0.2.4, thanks Alex!

@alexkalderimis
Copy link
Contributor Author

Released in 0.2.4, thanks Alex!

Thanks very much!

@alexkalderimis alexkalderimis deleted the ajk/better-required-messages branch October 31, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants