Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new custom resource for provider config and remove ConfigMap #329

Closed
11 tasks done
grahamia opened this issue Jul 3, 2024 · 1 comment · Fixed by #365
Closed
11 tasks done

Create new custom resource for provider config and remove ConfigMap #329

grahamia opened this issue Jul 3, 2024 · 1 comment · Fixed by #365
Assignees

Comments

@grahamia
Copy link
Contributor

grahamia commented Jul 3, 2024

Overview

Currently provider configuration and build of resources is all within the KFP-Operator helm install, this makes changing/adding new providers cumbersome and it should be split into its own custom resource which then controller for that will manage the creation/update/deletion of associated resources.

Work has already started on this on this branch: https://github.com/sky-uk/kfp-operator/tree/provider-crd

Acceptance Criteria

  • The existing provider ConfigMap should no longer exist
  • A custom resource for the newly defined CRD should replace the ConfigMap
  • When a Pipeline is created/updated, the workflow uses the custom resource and not the ConfigMap
  • When a RunConfiguration is created/updated, the workflow uses the custom resource and not the ConfigMap
  • When a RunSchedule is created/updated, the workflow uses the custom resource and not the ConfigMap
  • When a Run is created/updated, the workflow uses the custom resource and not the ConfigMap

Tasks

  • Define CRD (CustomResourceDefinition)
  • Custom resources will be created as part of the Operator helm chart (replacing the creation of the config map). Leave values for the provider CRD in the helm values.
  • Load configuration from the custom resource rather than mounting the config map
  • Configuration is passed from operator into workflow as raw data mounted in volume
  • Update documentation

Technical Details

See:

Example CR:

apiVersion: pipelines.kubeflow.org/v1alpha5
kind: Provider
metadata:
  name: provider-name (e.g. kfp/vai)
spec:
  image: provider-image-url:0.0.1
  executionMode: v1
  serviceAccount: kfp-operator
  defaultBeamArgs:
  - name: arg1
    value: value1
  pipelineRootStorage: file:///directory
  parameters:
    pipelineBucket: bucket-path
    etc: etc
@grahamia grahamia added enhancement New feature or request unrefined labels Jul 3, 2024
@grahamia grahamia added this to the Provider Custom Resource milestone Jul 3, 2024
@grahamia grahamia changed the title Extract provider config out of KFP-Operator into custom resource Extract provider config out of the provider config map into a new custom resource Jul 8, 2024
@grahamia grahamia removed unrefined enhancement New feature or request labels Jul 8, 2024
@grahamia
Copy link
Contributor Author

Need to rework provider into own chart first

@grahamia grahamia mentioned this issue Jul 22, 2024
8 tasks
@peter-hazell peter-hazell changed the title Extract provider config out of the provider config map into a new custom resource Create new custom resource for provider config and remove ConfigMap Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants