Provider helm chart #343
Merged
Provider helm chart #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamia
commented
Jul 19, 2024
| @@ -76,8 +76,18 @@ metadata: | |||
| spec: | |||
| volumes: | |||
| - name: providers-config | |||
| {{- if and (.Values.providers) (gt (len .Values.providers) 0) }} | |||
There was a problem hiding this comment.
This will be changed in next card when the config will be in the custom resource and KFP-Operator will inject as parameter to workflow
grahamia
force-pushed
the
provider-helm-chart
branch
from
91884d2 to
cca72b2
Compare
grahamia
commented
Jul 22, 2024
| @@ -1,4 +1,4 @@ | |||
| {{- if gt (len .Values.providers) 0 }} | |||
| {{- if .Values.statusFeedback.enabled }} | |||
There was a problem hiding this comment.
not a fan but again this is temporary till probably the public eventbus moves to provider helm and status updater replaced with webhook. This was just to keep feature same as existing
TobyPinfold
approved these changes
Jul 22, 2024
aidandunlop
reviewed
Jul 22, 2024
aidandunlop
reviewed
Jul 22, 2024
grahamia
force-pushed
the
provider-helm-chart
branch
from
6ffe56c to
d25ab13
Compare
aidandunlop
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #331
Splitting setup of provider specific resources into separate helm chart install.
Next task will be to change to provider crd and change the way config mounted into workflows to passing in as a parameter from the operator.