Fix/client server reconnection and timeout #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the reconnection edgecase where if the dmsg-server that we are trying to connect to is the last one and the method ce.EnsureSession returns an error then the reconnect gets stuck on the select statement waiting for either <-ce.done or <-ce.errCh and only moves when the done chan is closed. In order to fix that we send the error of the method ce.EnsureSession if the dmsg-server that we are trying to connect to is the last one.
jdknives
reviewed
Jun 2, 2022
| @@ -74,6 +74,10 @@ type Client struct { | |||
| conf *Config | |||
| porter *netutil.Porter | |||
|
|
|||
| bo time.Duration // initial backoff duration | |||
There was a problem hiding this comment.
Can we use the netutil.Retrier here?
There was a problem hiding this comment.
This commit fixes the read block caused in noise InitiatorHandshake when a dmsg server is closed improperly. Instead of using the func InitiatorHandshake we use the the method Handshake of ReadWriter which already has a timeout logic. The method Buffered is added to ReadWriter as it was needed in initClient and server to check the number of bytes that can be read from the buffer rawInput.
mrpalide
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #skywire-1233
Changes:
How to test this PR:
Given here