Fixes #75 Circle CI deploy in 0.25.1 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 27, 2019 09:48
…d defining the ENV TAG_DEPLOY to define when it is a release
…stall-deps-skyapi-Linux`
…buntu and Debian that support `add-apt-repository`
…cies of `skyapi ` in the image generated by `docker` in `Circle CI`
olemis
suggested changes
Jun 28, 2019
.circleci/config.yml
Outdated
| @@ -54,25 +54,28 @@ jobs: | |||
| - checkout | |||
| - setup_remote_docker: | |||
| version: 18.06.0-ce | |||
| - run: docker build --build-arg QEMU_PLATFORM --build-arg QEMU_OS=debian --file $GOPATH/src/github.com/skycoin/libskycoin/docker/images/test-arm/Dockerfile $GOPATH/src/github.com/skycoin/libskycoin -t skydev-test | |||
| - run: docker build --build-arg QEMU_PLATFORM --build-arg QEMU_OS=ubuntu --file $GOPATH/src/github.com/skycoin/libskycoin/docker/images/test-arm/Dockerfile $GOPATH/src/github.com/skycoin/libskycoin -t skydev-test | |||
There was a problem hiding this comment.
Gotta use Debian , Skycoin projects rely on Debian not Ubuntu .
…he libskycoin tests will be done.
olemis
suggested changes
Jun 28, 2019
docker/images/deploy-arm/Dockerfile
Outdated
| @@ -1,5 +1,5 @@ | |||
| ARG QEMU_PLATFORM | |||
| FROM balenalib/${QEMU_PLATFORM}-debian-golang | |||
| FROM balenalib/${QEMU_PLATFORM}-ubuntu-golang | |||
There was a problem hiding this comment.
shouldn't this be Debian ? Why Ubuntu ?
docker/images/deploy-arm/Dockerfile
Outdated
| @@ -10,17 +10,17 @@ ADD . $GOPATH/src/github.com/skycoin/libskycoin/ | |||
| RUN [ "cross-build-start" ] | |||
|
|
|||
| RUN ls -oa $GOPATH/src/github.com/skycoin/libskycoin/ | |||
| RUN sh $GOPATH/src/github.com/skycoin/libskycoin/ci-scripts/docker_install_debian.sh | |||
| RUN sh $GOPATH/src/github.com/skycoin/libskycoin/ci-scripts/docker_install_ubuntu.sh | |||
added 2 commits
June 28, 2019 16:09
…or the correct distro
olemis
approved these changes
Jun 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75