Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fyne to v2 #112

Merged
merged 44 commits into from
Oct 15, 2021
Merged

Update fyne to v2 #112

merged 44 commits into from
Oct 15, 2021

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Jun 22, 2021

Fixes #

Changes:

  • Updated fyne to v2
  • Changed depreciated functions
  • Changed from github.com/lucor/fyne-cross to github.com/fyne-io/fyne-cross

Does this change need to mentioned in CHANGELOG.md?

No

@jdknives
Copy link
Member

Running into /

usr/bin/docker run --rm -t -w /app -v /home/work/go/src/github.com/skycoin/skybian:/app -v /home/work/.cache/fyne-cross:/go -e CGO_ENABLED=1 -e GOCACHE=/go/go-build -e GOOS=linux -e GOARCH=amd64 -e CC=gcc -e fyne_uid=1000 lucor/fyne-cross:1.5.0 go build -ldflags ' -w -s' -o /app/fyne-cross/bin/linux-amd64/skyimager-gui -v ./cmd/skyimager-gui
build github.com/skycoin/skybian/cmd/skyimager-gui: cannot load embed: malformed module path "embed": missing dot in first path element
Could not build for linux/amd64: exit status 1
make: *** [Makefile:63: build-skyimager-gui] Fehler 1

@ersonp ersonp marked this pull request as ready for review July 5, 2021 16:42
@mrpalide
Copy link
Contributor

mrpalide commented Sep 29, 2021

New Changes:

  • [x] Add simple cache process to reduce getting image base urls from github
  • Change working directory from a simple text field to folder chooser by click on it
  • Cancel button not work during download base image

@jdknives
Copy link
Member

New Changes:

  • Add simple cache process to reduce getting image base urls from github
  • Add a button to reload urls more than once manually
  • Change working directory from a simple text field to folder chooser by click on it
  • Cancel button not work during download base image

@mrpalide some good ideas but not relevant for now. Please do not implement features that are not requested or were not implemented before. Please get the download cancel working button working and make the tests pass. Cache and URl reloading was not supported previously iirc.

@alexadhy
Copy link

alexadhy commented Sep 30, 2021

For cancel button:

Can't we just spawn another window in fyne ? then just add that progress bar and that cancel button to it, while disabling forms and button on the first window? just an idea

since that cancel button will not be called until after the progress bar finished, from the callstack, and that's I believe is the issue from the library itself the issue is the Download function is blocking UI event thread from running.

Since there's not a lot of differences between decoration-less Window and dialogs, I made it work with SplashWindow (mine is a 15 minutes bad hack)

dialog.mp4

jdknives and others added 3 commits October 14, 2021 15:11
AppVeyor does not recommend providing unencrypted environment variables
to non-origin repos. Consequently, the PR builds trying to access the
DOCKER_USERNAME and DOCKER_PASSWORD fail because they are only
accessible to builds from the origin repo. Removed the docker login
command on PR builds and left it for release builds.
Removed the build scripts for the 4 Skybian images from teh Linux jobs.
We should not build all four images for every commit as it effectively
blocks all other builds for up to an hour.
@jdknives jdknives merged commit 6cb3633 into skycoin:develop Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants