-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fyne to v2 #112
Update fyne to v2 #112
Conversation
Running into /
|
New Changes:
|
@mrpalide some good ideas but not relevant for now. Please do not implement features that are not requested or were not implemented before. Please get the download cancel working button working and make the tests pass. Cache and URl reloading was not supported previously iirc. |
For cancel button: Can't we just spawn another window in fyne ? then just add that progress bar and that cancel button to it, while disabling forms and button on the first window? just an idea since that cancel button will not be called until after the progress bar finished, from the callstack, and Since there's not a lot of differences between decoration-less Window and dialogs, I made it work with dialog.mp4 |
AppVeyor does not recommend providing unencrypted environment variables to non-origin repos. Consequently, the PR builds trying to access the DOCKER_USERNAME and DOCKER_PASSWORD fail because they are only accessible to builds from the origin repo. Removed the docker login command on PR builds and left it for release builds.
Removed the build scripts for the 4 Skybian images from teh Linux jobs. We should not build all four images for every commit as it effectively blocks all other builds for up to an hour.
Fixes #
Changes:
fyne
tov2
github.com/lucor/fyne-cross
togithub.com/fyne-io/fyne-cross
Does this change need to mentioned in CHANGELOG.md?
No