-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework to use packages / apt repo (WIP) #134
Conversation
Release v0.4.0
change skywire version to 0.5.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the skybian-script.tar.gz
archives doing in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the Skycoin.gpg key as txt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be no precompiled binaries in this PR. I dont see why we would need to have them. They are cluttering the repo as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be no precompiled binaries in this PR. I dont see why we would need to have them. They are cluttering the repo as well.
Overall, this seems very good. We get rid of a lot of code we need to maintain and the setup is much simplified.
There are a few areas we need to improve on overall though
- There should be no precompiled binaries in here. It is easy to compile binaries during the image build.
- I think having some subdirectories for the script folder may be helpful to figure out what stage scripts are invoked in or what function they serve.
- Similarly, a single line of comments at the top of scripts may help. Could simply state when its invoked (from where) and what it does.
- The README needs to be reworked. It does not seem properly structured to me. It should start with a brief overview over what this repo tries to achieve/provide. Then it can go on to install/build instructions.
it is added to the system in a file now, i think. so even if it was text in the build, it would be a file on the board. |
without an archive i would need to specify every file in the archives in the source array explicitly. Ive gotten into the habit of archiving any scripts and services i include in a package to make the build shorter. Same is done for the skycoin/AUR |
I was unable to install the crosscompilation dependencies from the AUR; builds are failing currently. I have them installed on my machines here but i cannot find the package that was installed, to install them on the build server. this http endpoint could be included with skywire-cli and avoid my having to crosscompile the binaries. |
@jdknives i generally agree with your final comments. Will make the changes ASAP. |
changes pushed to master outside of this PR |
This pull request hopes to accomplish the following:
Requires: archlinux based x86_64 / ARM / AARCH64 host.
Note: The changes in this PR are accompanied by changes in the skywire-autoconfig script and systemd services in the skywire-bin AUR package
Changes to the builds, scripts, and systemd services for skycoin packages in the AUR and the corresponding / derived .deb packages included in the apt repo at deb.skywire.skycoin.com can be tracked now on github at the-skycoin-project/AUR
Changes to skybian:
makepkg
Changes in skywire packaging:
Does this change need to mentioned in CHANGELOG.md?
Yes
Testing: