Merge pull request #700 from Darkren/fix/visor-gets-offline-after-rem…

…oval-of-underlying-vpn-tp Fix deadlock in managed tp's `updateStatus`
skycoin · Feb 27, 2021 · 19d88de · 19d88de
2 parents ee865e4 + 06e3a76
commit 19d88de
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/pkg/transport/managed_transport.go b/pkg/transport/managed_transport.go
@@ -471,10 +471,10 @@ func (mt *ManagedTransport) updateStatus(isUp bool, tries int) (err error) {
 	}()
 
 	mt.isUpMux.Lock()
+	defer mt.isUpMux.Unlock()
 
 	// If last update is the same as current, nothing needs to be done.
 	if mt.isUp == isUp {
-		mt.isUpMux.Unlock()
 		return nil
 	}
 
@@ -515,7 +515,6 @@ func (mt *ManagedTransport) updateStatus(isUp bool, tries int) (err error) {
 
 	mt.isUp = isUp
 	mt.isUpErr = err
-	mt.isUpMux.Unlock()
 	return err
 }