Refactor route group tests

skycoin · Jan 30, 2020 · 46879d8 · 46879d8
1 parent 58787e5
commit 46879d8
Show file tree

Hide file tree

Showing 2 changed files with 111 additions and 315 deletions.
diff --git a/pkg/router/route_group.go b/pkg/router/route_group.go
@@ -194,8 +194,6 @@ func (rg *RouteGroup) Write(p []byte) (n int, err error) {
 	}
 
 	rg.mu.Lock()
-	//defer rg.mu.Unlock()
-
 	tp, err := rg.tp()
 	if err != nil {
 		rg.mu.Unlock()
@@ -207,7 +205,7 @@ func (rg *RouteGroup) Write(p []byte) (n int, err error) {
 		rg.mu.Unlock()
 		return 0, err
 	}
-
+	// we don't need to keep holding mutex from this point on
 	rg.mu.Unlock()
 
 	return rg.write(p, tp, rule)