Fix lock in the managed routing table

skycoin · Aug 23, 2019 · 4d6f014 · 4d6f014
1 parent 9b3ad84
commit 4d6f014
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pkg/router/managed_routing_table.go b/pkg/router/managed_routing_table.go
@@ -28,15 +28,16 @@ func manageRoutingTable(rt routing.Table) *managedRoutingTable {
 }
 
 func (rt *managedRoutingTable) AddRule(rule routing.Rule) (routing.RouteID, error) {
+	rt.mu.Lock()
+	defer rt.mu.Unlock()
+
 	routeID, err := rt.Table.AddRule(rule)
 	if err != nil {
 		return 0, err
 	}
 
-	rt.mu.Lock()
 	// set the initial activity for rule not to be timed out instantly
 	rt.activity[routeID] = time.Now()
-	rt.mu.Unlock()
 
 	return routeID, nil
 }