Skip to content

Commit

Permalink
Run linters in vendor mode
Browse files Browse the repository at this point in the history
  • Loading branch information
nkryuchkov committed Jul 22, 2019
1 parent f72b6d6 commit 8e9a4b8
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
10 changes: 10 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ run:
# autogenerated files. If it's not please let us know.
skip-files:

# by default isn't set. If set we pass it to "go list -mod={option}". From "go help modules":
# If invoked with -mod=readonly, the go command is disallowed from the implicit
# automatic updating of go.mod described above. Instead, it fails when any changes
# to go.mod are needed. This setting is most useful to check that go.mod does
# not need updates, such as in a continuous integration and testing system.
# If invoked with -mod=vendor, the go command assumes that the vendor
# directory holds the correct copies of dependencies and ignores
# the dependency descriptions in go.mod.
modules-download-mode: vendor


# output configuration options
output:
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
.PHONY : docker-apps docker-bin docker-volume
.PHONY : docker-run docker-stop

OPTS?=GO111MODULE=on
OPTS?=GO111MODULE=on
DOCKER_IMAGE?=skywire-runner # docker image to use for running skywire-visor.`golang`, `buildpack-deps:stretch-scm` is OK too
DOCKER_NETWORK?=SKYNET
DOCKER_NODE?=SKY01
Expand Down Expand Up @@ -45,7 +45,7 @@ rerun: stop
lint: ## Run linters. Use make install-linters first
${OPTS} golangci-lint run -c .golangci.yml ./...
# The govet version in golangci-lint is out of date and has spurious warnings, run it separately
${OPTS} go vet -all ./...
${OPTS} go vet -mod=vendor -all ./...

vendorcheck: ## Run vendorcheck
GO111MODULE=off vendorcheck ./internal/...
Expand Down

0 comments on commit 8e9a4b8

Please sign in to comment.