Skip to content

Commit

Permalink
Add a comment with an explanation
Browse files Browse the repository at this point in the history
  • Loading branch information
nkryuchkov committed Jan 22, 2020
1 parent 9cd6b23 commit d7f82f6
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkg/app/appserver/proc_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ func (m *procManager) Wait(name string) error {
return err
}

// While waiting for p.Wait() call, we need app to present in the processes list,
// so we cannot pop it before p.Wait().
if err := p.Wait(); err != nil {
if _, ok := err.(*exec.ExitError); !ok {
err = fmt.Errorf("failed to run app executable %s: %v", name, err)
Expand Down

0 comments on commit d7f82f6

Please sign in to comment.