Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to configure the port of the skysocks-client app #354

Closed
Senyoret1 opened this issue Apr 29, 2020 · 2 comments
Closed

Add a way to configure the port of the skysocks-client app #354

Senyoret1 opened this issue Apr 29, 2020 · 2 comments

Comments

@Senyoret1
Copy link
Contributor

Feature description
Currently the PUT api/visors/{{pk}}/apps/skysocks-client API endpoint allows to change the public key used by the skysocks-client app, but not the port. This is an important problem because the Skywire manager uses the proxy discovery service for allowing the user to select a remote visor to connect to and the PUT api/visors/{{pk}}/apps/skysocks-client API endpoint to change the configuration of the app, but that service returns not just the public key, but also the port, and there is no way for using that port via the API.

Is your feature request related to a problem? Please describe.
An option is to add a new param to the API endpoint.

Describe alternatives you've considered
Long term, adding app specific params to a generic endpoint like PUT api/visors/{{pk}}/apps/{{app-name}} may be problematic. But as a short term fix it may work.

@jdknives
Copy link
Member

@Senyoret1 it is not really expected that the skysocks server would run on a port other than 3 so strictly speaking, we do not need to display that at all yet. The port number will be relevant when we have non-default apps running and advertising themselves. We can omit the port for now in the hypervisor.

@Senyoret1
Copy link
Contributor Author

Oh, ok. I added the changes to the PR: #326 (comment) . this issue is not longer needed then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants