Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional features for configuring skysocks-client in the manager #326

Merged
merged 7 commits into from
Aug 14, 2020
Merged

Additional features for configuring skysocks-client in the manager #326

merged 7 commits into from
Aug 14, 2020

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Maybe Fixes #314

Changes:

  • Now the configuration modal window for the skysocks-client app shows the list of nodes obtained from the proxy discovery service. Options for filtering the list were added.
  • The history has been improved.
  • Various other small improvements.

Notes:

  • This PR includes the changes made in Improvements for the manager #315
  • The PR still lack pagination options.
  • The PR is currently connecting to a local instance of the proxy discovery service.
  • The list obtained from the proxy discovery service does not include information about the auth state, so it was not possible to include that information or to use it for filtering.

How to test this PR:
Use the make integration-run-proxy command of the skywire-services repo and check the configuration options of the skysocks-client app.

@Senyoret1
Copy link
Contributor Author

The last commits update the branch and include pagination for the proxy discovery tab of the skysocks-client config modal window.

@Senyoret1
Copy link
Contributor Author

The lastest commit includes the following changes:

  • The code for connecting the manager to the proxy discovery service was updated to work with the lastest version of the service.
  • Elements which are no longer available in the proxy discovery service were removed from the UI.
  • Now, when filtering the results of the proxy discovery service, the UI highlights in the results the terms the user used as filters.
  • Now, in production builds, the url used for connecting with the proxy discovery service is http://proxy.discovery.skywire.cc. In dev builds the connection is made to a local instance of the proxy discovery service via the dev server proxy, to avoid problems with the CORS policy.

@Senyoret1
Copy link
Contributor Author

The lasteast commit includes the following changes:

  • Now the connection to the proxy discovery service is made using https if the manager was openned using https.
  • The port was removed from the UI of the proxy discovery service.

@Senyoret1
Copy link
Contributor Author

The previous commits where cherry picked and force push was used to make the PR work well with the changes made to the develop branch.

@Senyoret1
Copy link
Contributor Author

The last commits include the following changes:

  • The conflicts were solved.
  • Some changes were made to make the PR continue working.

@Senyoret1
Copy link
Contributor Author

The last commits include the following changes:

  • Now the discovery service is accessible from http and https.
  • The separators of the list now have the correct color.

@Senyoret1 Senyoret1 changed the title [WIP] Additional features for configuring skysocks-client in the manager Additional features for configuring skysocks-client in the manager Aug 13, 2020
@jdknives jdknives merged commit 7f40cfa into skycoin:develop Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants