Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for the links in the app list #1128

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Improvements for the links in the app list #1128

merged 2 commits into from
Mar 9, 2022

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Fixes #1097

Changes:

  • A link for opening the VPN client UI was added to the app list.
  • Now the link for opening the skychat app appears only if the app is running, as the UI does not work if the app is stopped.
    apps

How to test this PR:
Open the Skywire manager UI and go to the app list of a visor. Check the links in the list.

NOTE:
We could say that now there are 2 UIs for the VPN client, the one that is accessible with the link and the modal window that
appears when clicking on the gear button. @jdknives Maybe the modal window can be removed.

@jdknives
Copy link
Member

jdknives commented Mar 9, 2022

@Senyoret1 I think we can remove the modal. Need to double check if there is any feature we have in it we dont have in the full UI.

@jdknives
Copy link
Member

jdknives commented Mar 9, 2022

⠧ Generating browser application bundles (phase: building)...node:internal/crypto/hash:67
  this[kHandle] = new _Hash(algorithm, xofLen);
                  ^

Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:67:19)
    at Object.createHash (node:crypto:135:10)
    at BulkUpdateDecorator.hashFactory (/home/theodore/go/src/github.com/skycoin/skywire/static/skywire-manager-src/node_modules/webpack/lib/util/createHash.js:145:18)
    at BulkUpdateDecorator.update (/home/theodore/go/src/github.com/skycoin/skywire/static/skywire-manager-src/node_modules/webpack/lib/util/createHash.js:46:50)
    at RawSource.updateHash (/home/theodore/go/src/github.com/skycoin/skywire/static/skywire-manager-src/node_modules/webpack/node_modules/webpack-sources/lib/RawSource.js:77:8)
    at NormalModule._initBuildHash (/home/theodore/go/src/github.com/skycoin/skywire/static/skywire-manager-src/node_modules/webpack/lib/NormalModule.js:880:17)
    at handleParseResult (/home/theodore/go/src/github.com/skycoin/skywire/static/skywire-manager-src/node_modules/webpack/lib/NormalModule.js:946:10)
    at /home/theodore/go/src/github.com/skycoin/skywire/static/skywire-manager-src/node_modules/webpack/lib/NormalModule.js:1040:4
    at processResult (/home/theodore/go/src/github.com/skycoin/skywire/static/skywire-manager-src/node_modules/webpack/lib/NormalModule.js:755:11)
    at /home/theodore/go/src/github.com/skycoin/skywire/static/skywire-manager-src/node_modules/webpack/lib/NormalModule.js:819:5 {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

Node.js v17.6.0
make: *** [Makefile:235: build-ui] Error 1

@Senyoret1
Copy link
Contributor Author

The last commit includes the last changes from develop

@jdknives jdknives merged commit c3a9558 into skycoin:develop Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants