Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manipulate goreleaser and appveyor for release from appveyor #1226

Merged
merged 18 commits into from
May 31, 2022
Merged

manipulate goreleaser and appveyor for release from appveyor #1226

merged 18 commits into from
May 31, 2022

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented May 26, 2022

Did you run make format && make check? Yes

Fixes # -

Changes:

  • Separate linux and darwin/windows build.
  • Fix AppVeyor to do releases more straightforward, with just push new tags

How to test this PR:

  • For test linux release, test on linux machine by make dep-github-release && make snapshot linux command.
  • For darwin/windows build, just run make snapshot command on mca os machine.
  • Actually for push new release, after merge this PR, we just need set new tag and push it to repo. Both develop and master branches are OK to get tag.
  • Also I test on my fork, this is release, and this is AppVeyor logs.

@mrpalide mrpalide marked this pull request as ready for review May 26, 2022 12:57
Makefile Outdated Show resolved Hide resolved
.goreleaser-static.yml Outdated Show resolved Hide resolved
@jdknives
Copy link
Member

Summarising the discussion on Matrix:

  • as it looks like we can do static builds with musl for the systray versions, we can get rid of the dynamic build config and just use the static goreleaser config as the default and only one available for releases
  • please use the cross compilers available here https://musl.cc/#binaries or elsewhere to compile all binaries with musl

@jdknives jdknives merged commit 420e8cb into skycoin:develop May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants