Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Windows Installer Script #1253

Merged
merged 9 commits into from
Jun 21, 2022
Merged

Improve Windows Installer Script #1253

merged 9 commits into from
Jun 21, 2022

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Jun 10, 2022

Did you run make format && make check? Yes

Fixes #-

Changes:

  • change/refactor script.ps1 of windows installer
  • add win-installer-latest to Makefile for create installer on last release. (Currently, we don't have needed archive file for v0.6.0, but will available for v1.0.0 release)
  • add CUSTOM_VERSION parameter to win-installer command to create installer for specific version. Could use for both released or pre-release releases.

How to test this PR:

  • use make win-installer CUSTOM_VERSION=v1.0.0-rc5 for test this

Except Behavior:

  • Console logs should be like this:

    image

  • And two msi installer file should created by these names:

    • skywire-systray-v1.0.0-rc5-windows-amd64.msi
    • skywire-systray-v1.0.0-rc5-windows-386.msi

@ersonp
Copy link
Contributor

ersonp commented Jun 16, 2022

The rc-5 release has no windows-arm64 Archive

#    => Create Installer for arm64                       #
#       1. Preparing Stage...                            #
#       2. Fetching Archive from GitHub...               #
https://github.com/skycoin/skywire/releases/download/v1.0.0-rc5/skywire-systray-v1.0.0-rc5-windows-arm64.zip
Invoke-WebRequest : Not Found
At C:\skywire\scripts\win_installer\script.ps1:44 char:9
+         Invoke-WebRequest $downloadURL -o archive.zip
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [Invoke-WebRequest], WebExc
   eption
    + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeWebRequestCommand
make: *** [Makefile:386: win-installer] Error 1```

@ersonp ersonp merged commit 419e836 into skycoin:develop Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants