Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use page state management #1571

Merged
merged 1 commit into from
May 25, 2023
Merged

Use page state management #1571

merged 1 commit into from
May 25, 2023

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run build wes used. npm run lint could have problems for the update to Angular 16.

Changes:

  • The last commit makes the whole app use page state management, as it is more usable with the new verisons of Angular. This makes the app remember the system state while navigating, which means remembering the scroll position, avoid reloading previously loaded data from the server and other usability improvements. This should be more noticeable on mobile devices.

This is similar a previous change made to the explorer, but with some changes, because the router strategy used by the Hypervisor UI in the router config is different.

How to test this PR:
After recompiling the front-end, when navigating with the browser buttons the app should now remember the scroll position and some parts of the app should load a bit faster.

@jdknives jdknives merged commit 84d6cdf into skycoin:develop May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants