Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "github.com/skycoin/skywire-utilities" imports with "github.com/skycoin/skywire/pkg/skywire-utilities" #1912

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

0pcom
Copy link
Collaborator

@0pcom 0pcom commented Dec 17, 2024

  • replace imports

@0pcom
Copy link
Collaborator Author

0pcom commented Dec 17, 2024

This will temporarily break skywire on develop until the dmsg, skywire-services, and skycoin-service-discovery repos are changed to the new import path.

Adding the skywire-utilities package did not allow dmsg to work because it's still importing skywire which currently imports skywire-utilities (that is changed in this PR).

However, replacing the skywire import in dmsg with the local changes reflected in this PR allowed it to work.

So this PR needs to be merged first as this is the only viable alternative. And then the other repos will be updated with the commit here before another PR updates the import commits for those repos in go.mod here

@0pcom 0pcom merged commit cb65518 into skycoin:develop Dec 17, 2024
0 of 3 checks passed
@0pcom 0pcom deleted the skywire-utilities branch December 17, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant