Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter and tests on 32-bit architectures #199

Merged
merged 4 commits into from
Mar 4, 2020
Merged

Fix linter and tests on 32-bit architectures #199

merged 4 commits into from
Mar 4, 2020

Conversation

nkryuchkov
Copy link
Contributor

Did you run make format && make check? Yes

Fixes #194

Changes:

  • Implement struct fields alignment calculation
  • Fix linter on 32-bit ARM
  • Remove -race flag for tests on 32-bit architectures because it's not supported, so tests failed

How to test this PR:
Run make check on 32-bit ARM.

@nkryuchkov nkryuchkov requested a review from jdknives March 4, 2020 18:44
jdknives
jdknives approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests run well now. Good job.

@jdknives
Copy link
Member

jdknives commented Mar 4, 2020

--- FAIL: TestRouteGroup_TestConn/FutureTimeout (0.66s)
This test fails consistently on the Pi.
log.txt

@jdknives jdknives merged commit 8e03b43 into skycoin:milestone2 Mar 4, 2020
@jdknives jdknives mentioned this pull request Mar 4, 2020
Closed
@nkryuchkov nkryuchkov deleted the fix/arm32-tests branch March 13, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Router tests fail on 32-bit RPi
2 participants
@nkryuchkov @jdknives