Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPN improvements #356

Merged
merged 71 commits into from
May 21, 2020
Merged

VPN improvements #356

merged 71 commits into from
May 21, 2020

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented May 1, 2020 •
edited by jdknives
Loading

Did you run make format && make check?
Yes

Fixes #347 Fixes #343

Changes:

  • Added passcode to authenticate VPN client within the server
  • Added RPC calls to changes passcode for both client and server
  • Added RPC call to change remote PK for client
  • Modified hypervisor's putApp API method to perform the RPC calls mentioned above
  • Added an ability to run this guy on Windows

How to test this PR:

  • Passcode
  1. Add "-passcode", "some_passcode" to the args parameter of both server and client configs
  2. Try to connect. Correct password will result in successful traffic exchange, incorrect password will result in Forbidden status in client logs
  • RPC calls
    Try calling the hypervisor API to change passcode and PK. Passcode may be changed for both server and client. Functionality takes place in the putApp method, the same as used to change PK and passcode for skysocks apps

@Darkren Darkren changed the title VPN improvements [WIP] VPN improvements May 1, 2020
jdknives
jdknives reviewed May 1, 2020
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work well so far. Should the VPN app stop upon not successfully registering with a remote server?

Darkren added 18 commits May 4, 2020 13:44
@Darkren
Add README.md for VPN client
fe810c4
@Darkren
Add README.md for VPN server, fix client's one a bit
bffe337
@Darkren
Make default network gateway detection work via ip r for Linux systems
53deb0a
@Darkren
Fix default network gateway detection
a33d0a0
@Darkren
Fix it once again
8f6a3f6
@Darkren
Make TUN setup go via ip for Linux systems
249e20b
@Darkren
Fix Linux code
253ca86
@Darkren
Try to fix
460be43
@Darkren
Make all routing be done via 'ip` for Linux systems
7768f2a
@Darkren
Remove some duplicate code
446b17b
@Darkren
Substitute logrus sys log hook with our wrapper
1f87aae
@Darkren
Implement DefaultNetworkGateway for Windows
da60cdf
@Darkren
Finish TUN setup for Windows
9ec65d2
@Darkren
Fix sys log build for Windows
37ad9b2
@Darkren
Merge branch 'feature/vpn-improvements' of https://github.com/Darkren…
8aac4ea 
…/skywire-mainnet into feature/vpn-improvements
@Darkren
Refactor all os-related funcs
ee66dc1
@Darkren
Fix DefaultNetworkInterface for Linux systems
6153391
@Darkren
Add routing commands for Windows
932d4df
@Darkren Darkren changed the title [WIP] VPN improvements VPN improvements May 19, 2020
jdknives
jdknives approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works smoothly for me. I could not test the Windows setup unfortunately.

evanlinjin
evanlinjin reviewed May 21, 2020
View reviewed changes
Copy link
Contributor

@evanlinjin evanlinjin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work and clean code. Some of my comments are due to personal taste, if you don't agree with them, feel free to ignore it! 😅

internal/vpn/client.go Show resolved Hide resolved
internal/vpn/errors.go Outdated Show resolved Hide resolved
internal/vpn/noise_credentials.go Show resolved Hide resolved
internal/vpn/os_client_darwin.go Show resolved Hide resolved
nkryuchkov
nkryuchkov approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@nkryuchkov nkryuchkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

README.md Outdated Show resolved Hide resolved
internal/vpn/net.go Outdated Show resolved Hide resolved
pkg/visor/init.go Outdated Show resolved Hide resolved
@evanlinjin evanlinjin merged commit 49ef1cf into skycoin:develop May 21, 2020
@Darkren Darkren deleted the feature/vpn-improvements branch August 21, 2020 11:29
jdknives pushed a commit that referenced this pull request Oct 19, 2020
Merge pull request #356 from Darkren/feature/vpn-improvements
b918e10 
VPN improvements

Former-commit-id: 49ef1cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

@nkryuchkov nkryuchkov nkryuchkov approved these changes

@evanlinjin evanlinjin evanlinjin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Darkren @evanlinjin @nkryuchkov @jdknives