Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlock in managed tp's updateStatus #700

Merged
merged 5 commits into from
Feb 27, 2021
+1 −2
Merged

Fix deadlock in managed tp's updateStatus #700

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e74dbcb
Add debug logs
Darkren Feb 24, 2021
306c207
Add debug logs
Darkren Feb 26, 2021
948cc0a
Fix deadlock in managed tp's `updateStatus`
Darkren Feb 26, 2021
84329a1
Merge branch 'develop' of github.com:skycoin/skywire into fix/visor-g…
Darkren Feb 26, 2021
06e3a76
Remove debug logs
Darkren Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pkg/transport/managed_transport.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,10 +471,10 @@ func (mt *ManagedTransport) updateStatus(isUp bool, tries int) (err error) {
}()

mt.isUpMux.Lock()
defer mt.isUpMux.Unlock()

// If last update is the same as current, nothing needs to be done.
if mt.isUp == isUp {
mt.isUpMux.Unlock()
return nil
}

Expand Down Expand Up @@ -515,7 +515,6 @@ func (mt *ManagedTransport) updateStatus(isUp bool, tries int) (err error) {

mt.isUp = isUp
mt.isUpErr = err
mt.isUpMux.Unlock()
return err
}

Expand Down