BugFix - Removed Image Balloon on Poster, BackArrow Icon now works on click #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…licked, to display the balloon at the bottom of the poster. Now when it is clicked it will go back to the previous activity.
skydoves
reviewed
May 7, 2021
app/src/main/java/com/skydoves/disneycompose/ui/details/PosterDetails.kt
Show resolved
Hide resolved
blizzyblake278
commented
May 7, 2021
skydoves
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when the back arrow icon was pressed on the poster image, the balloon displayed at the bottom of the poster with the title of the movie. Now when the back arrow is pressed, it will go back to the previous screen. User could press the back arrow on the phone, but that defeated the purpose of the back arrow icon on the poster as well I felt.
I should mention this is my first contribution too to an open source project outside of my own, but I felt I followed the directions to allow this fix. If not please let me know and I will listen to the feedback. Thank you.
Guidelines
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce?
Preparing a pull request for review
Ensure your change is properly formatted by running:
$ ./gradlew spotlessApplyPlease correct any failures before requesting a review.