Added Web Component shadowDOM support #2966
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadow DOM support and unit tests Added getSelection() polyfill for Safari shadow DOM
Closed
edave64
reviewed
Jul 21, 2024
| @@ -20,6 +19,7 @@ class Emitter extends EventEmitter { | |||
| constructor() { | |||
| super(); | |||
| this.listeners = {}; | |||
| EMITTERS.push(this); | |||
There was a problem hiding this comment.
This is a memory leak. When Quill editors are being dynamically created and destroyed, these emitters will live forever, keeping their listeners alive and with them much of the quill instance.
Previously the emitter was only held by the quill instance and the DOM, now it's global.
So this probably needs to be an array of WeakRefs, or Quill gets a dispose method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Custom toolbar not able to create.
RCA: quill was using document object to find elements.
Solution: added check if quill editor is rendered inside shadowDOM or inside document