Add ListTeams and TeamAccess{Granted,Revoked}Events and fix missing enterprise ID #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenwan-opal
force-pushed
the
master
branch
2 times, most recently
from
2cf2d3d
to
aceca79
Compare
stephenwan-opal
changed the title
kanata2
requested changes
Oct 31, 2022
conversation.go
Outdated
Comment on lines
356
to
357
| "is_private": {strconv.FormatBool(params.IsPrivate)}, | ||
| "team_id": {params.TeamID}, |
There was a problem hiding this comment.
I'm not sure I understand the behavior when passing an empty parameter... it is better to skip if these fields are empty.
There was a problem hiding this comment.
done, thanks!
kanata2
added
feedback given
stephenwan-opal
force-pushed
the
master
branch
2 times, most recently
from
6f7f1c1
to
d0de2c2
Compare
|
@kanata2 thank you for reviewing - i addressed/responded to the PR comments |
|
@kanata2 thanks again for reviewing - could you take a look at the new changes here? |
|
Sorry for delay. I'll confirm within a few days. |
kanata2
added
needs review
and removed
feedback given
Before this change, innerEvent.EnterpriseID was always empty string. Now, it is filled when available from the outer event.
This is a breaking change that hopefully future proofs this codepath from future breaking changes, since adding additional params to the struct should be backwards compatible.
stephenwan-opal
force-pushed
the
master
branch
from
d0de2c2
to
2d81614
Compare
kanata2
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes useful for building Slack Enterprise Grid integrations.
team_access_grantedandteam_access_revokedeventsListTeamsto callauth.teams.listEnterpriseIDis not filled in the events api for callback eventsTeamIDtoCreateConversation. This is a breaking change, but hopefully one that prevents future breaking changes.