Code

Socket Mode support#885

Code

Merged

kanata2 merged 57 commits intoslack-go:masterslack-go/slack:masterfrom mumoshu:socket-modemumoshu/slack:socket-modeCopy head branch name to clipboardJan 19, 2021

+1,411-34

Commits

Commits on Jan 14, 2021

• WIP: Socket Mode support

  Show description for 2873e9b
  mumoshu

  committed
  2873e9b

  Copy full SHA for 2873e9b

Commits on Jan 15, 2021

• Use app token for opening socket mode connection

  mumoshu

  committed
  14923f2

  Copy full SHA for 14923f2

• Move Socket Mode support to the slacksocketmode pkg to avoid import cycle

  mumoshu

  committed
  ff6e556

  Copy full SHA for ff6e556

• Move backoff to the internal/backoff pkg for sharing between slack pkg and slacksocketmode pkg

  mumoshu

  committed
  88c913f

  Copy full SHA for 88c913f

• Fix the comment on ack method

  mumoshu

  committed
  493fd6f

  Copy full SHA for 493fd6f

• Remove invalid comment left due to copy-paste on SocketModeClient.connect

  mumoshu

  committed
  d472ffd

  Copy full SHA for d472ffd

• Fix SocketModeClient receiver name

  mumoshu

  committed
  e97de46

  Copy full SHA for e97de46

• Various renames on Socket Mode related symbols for ease of use and consistency

  mumoshu

  committed
  f5c72e4

  Copy full SHA for f5c72e4

Commits on Jan 16, 2021

• Move statusCodeError into the internal pkg for use from slacksocketmode

  mumoshu

  committed
  08f68aa

  Copy full SHA for 08f68aa

• The initial version that manually verified to work

  mumoshu

  committed
  155b2bc

  Copy full SHA for 155b2bc

• Fix log message

  mumoshu

  committed
  cf7f3ca

  Copy full SHA for cf7f3ca

• Better debug logs (may be removed before merging)

  mumoshu

  committed
  38b0347

  Copy full SHA for 38b0347

• Change socketmode example source file name for consistency

  mumoshu

  committed
  b53014b

  Copy full SHA for b53014b

• Call it a Socket Mode "Request" rather than "Message" or "Event" for clarity

  mumoshu

  committed
  4e25959

  Copy full SHA for 4e25959

• More restructuring for readability

  mumoshu

  committed
  528677c

  Copy full SHA for 528677c

• Refactor socket mode deadman for clarity

  mumoshu

  committed
  5e41380

  Copy full SHA for 5e41380

• More Event and Request distinction in code-base

  mumoshu

  committed
  1a23793

  Copy full SHA for 1a23793

• Fix socket mode debug log message

  mumoshu

  committed
  0d6994c

  Copy full SHA for 0d6994c

• Remove unnecessary call to SetCloseHandler

  mumoshu

  committed
  1da2c76

  Copy full SHA for 1da2c76

• Send back PONG to Slack via WebSocket in Socket Mode

  mumoshu

  committed
  5b8a218

  Copy full SHA for 5b8a218

• Delete unused handleAck function for slacksocketmode

  mumoshu

  committed
  e5d2f1a

  Copy full SHA for e5d2f1a

• Serialize writes to WebSocket for Socket Mode ACKs

  mumoshu

  committed
  c269a17

  Copy full SHA for c269a17

• Rename slacksocketmode to socketmode

  mumoshu

  committed
  852061e

  Copy full SHA for 852061e

• Merge internalEvent and externalEvent

  mumoshu

  committed
  11f20f3

  Copy full SHA for 11f20f3

• Apply goimports

  mumoshu

  committed
  3cd2344

  Copy full SHA for 3cd2344

• Give socketmode Response a dedicated source file

  mumoshu

  committed
  7e8a5a7

  Copy full SHA for 7e8a5a7

• Fix an incorrect envvar name in socketmode example

  mumoshu

  committed
  93c9b45

  Copy full SHA for 93c9b45

• Cover all the possible Socket Mode request types

  mumoshu

  committed
  88722e9

  Copy full SHA for 88722e9

• This may make govet lint happy

  mumoshu

  committed
  f0a6dde

  Copy full SHA for f0a6dde

• Add support for receiving interactive and slash_commands requests from Slack and send respective events to the consumer for Socket Mode

  mumoshu

  committed
  0be002a

  Copy full SHA for 0be002a

• Force the consumer to explicitly ack the socket mode request and verify it works with interactions and slash commands

  mumoshu

  committed
  24cf166

  Copy full SHA for 24cf166

Commits on Jan 17, 2021

• Various cleanups

  mumoshu

  committed
  1265022

  Copy full SHA for 1265022

• Rename pingInterval to maxPingInterval for clarity

  mumoshu

  committed
  10850e1

  Copy full SHA for 10850e1

• Add missing Debugf func

  mumoshu

  committed
  ebbe82a

  Copy full SHA for ebbe82a

• Various fixes regarding build errors

  mumoshu

  committed
  860b3a2

  Copy full SHA for 860b3a2

• Remove the private variant of Ack func and add comments

  mumoshu

  committed
  aa57150

  Copy full SHA for aa57150

• Remove unneeded ticker in socket mode message handler

  mumoshu

  committed
  679c9a6

  Copy full SHA for 679c9a6

• socketmode: Make WebSocket message handling core a bit more side-effect free for testability

  mumoshu

  committed
  40cedb3

  Copy full SHA for 40cedb3

• Distinguish among done vs disconnect vs reconnect

  mumoshu

  committed
  ff9e9fd

  Copy full SHA for ff9e9fd

• socket mode: Add support for disconnect and reconnect on request from Slack

  mumoshu

  committed
  91b8ac7

  Copy full SHA for 91b8ac7

• socket mode: Make Run() a bit more easy to read

  mumoshu

  committed
  e5a4822

  Copy full SHA for e5a4822

• socket mode: Make slash-command related event value consistent with request counterpart

  mumoshu

  committed
  5a2d8db

  Copy full SHA for 5a2d8db

• Fix examples/socketmode for invalid member-joined-channel event matching and handling

  mumoshu

  committed
  18c4fd2

  Copy full SHA for 18c4fd2

• socketmode: Add support for Go 1.12

  mumoshu

  committed
  9335441

  Copy full SHA for 9335441

Commits on Jan 18, 2021

• More unit tests for socket mode request parsing and some tweaks

  mumoshu

  committed
  b2bfdf1

  Copy full SHA for b2bfdf1

• socketmode: Fix logger for correct line numbers in messages

  mumoshu

  committed
  eaaf0e0

  Copy full SHA for eaaf0e0

• socketmode: Remove unused idGen

  mumoshu

  committed
  a606305

  Copy full SHA for a606305

• socketmode: Fix comment on Client.Open()

  mumoshu

  committed
  93df48b

  Copy full SHA for 93df48b

• socketmode: make receiver name "smc"

  mumoshu

  committed
  d7a26ac

  Copy full SHA for d7a26ac

• socketmode: Remove RTM-ness from comments on log messages

  mumoshu

  committed
  2cf901c

  Copy full SHA for 2cf901c

• socketmode: Use EventType constants everywhere

  mumoshu

  committed
  2cbdf3b

  Copy full SHA for 2cbdf3b

• socketmode: Update the example with connectino lifecycle events

  mumoshu

  committed
  04ead06

  Copy full SHA for 04ead06

• socketmode: prepare costly log data only on debug mode

  mumoshu

  committed
  e9e7822

  Copy full SHA for e9e7822

• Remove unnecessary commented-out line

  mumoshu

  committed
  c0cd3da

  Copy full SHA for c0cd3da

• Fix comment on StartSocketModeContext

  mumoshu

  committed
  fcf2b1e

  Copy full SHA for fcf2b1e

Commits on Jan 19, 2021

• socketmode: Brush up comment on socketmode.Client

  mumoshu

  committed
  0f4bd7d

  Copy full SHA for 0f4bd7d

• socketmode: Make internal error private to the pkg as it should

  mumoshu

  committed
  0fbd39a

  Copy full SHA for 0fbd39a