Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtm.start happens synchronously under client.start_async #87

Open
dblock opened this issue May 4, 2016 · 1 comment
Open

rtm.start happens synchronously under client.start_async #87

dblock opened this issue May 4, 2016 · 1 comment
Labels
new feature realtime api

Comments

@dblock
Copy link
Collaborator

dblock commented May 4, 2016

Move rtm.start into an async operation. This will affect downstream clients as they currently rely on exceptions being thrown synchronously.
dblock added a commit that referenced this issue May 4, 2016
@dblock
The rtm.start part of setting up a RealTime client will happen asynch…
bdbb4a5 
…ronously with start_async.

Closes #87.
@dblock
Copy link
Collaborator Author

dblock commented May 4, 2016

The change in dblock@bdbb4a5 sets it up in parallel, but IO is not actually happening asynchronously, so there's no real benefit. Would need to switch web_client's HTTP stack to something that happens in parallel.

This was referenced May 5, 2016
Closed
Closed
@dblock dblock mentioned this issue Jun 5, 2016
Open
@dblock dblock mentioned this issue Oct 10, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature realtime api
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dblock